This revision was automatically updated to reflect the committed changes.
Closed by commit rL318446: Remove a FIXME about truncated section names
(authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D39918?vs=122498&id=123223#toc
Repository:
rL LLVM
https://reviews.llvm
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Yep, no need for this.
https://reviews.llvm.org/D39918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
mstorsjo added a comment.
@rnk I guess this is ok now as https://reviews.llvm.org/D40025 is committed and
done?
https://reviews.llvm.org/D39918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
mstorsjo added a comment.
In https://reviews.llvm.org/D39918#923070, @ruiu wrote:
> Actually I don't have a strong opinion on that topic. It seems like just
> truncating the section name to ".eh_fram" at the linker is good enough, but
> how much important is the compatibility with GNU ld?
It'
ruiu added a comment.
Actually I don't have a strong opinion on that topic. It seems like just
truncating the section name to ".eh_fram" at the linker is good enough, but how
much important is the compatibility with GNU ld?
https://reviews.llvm.org/D39918
___
mstorsjo added a comment.
In https://reviews.llvm.org/D39918#923059, @ruiu wrote:
> I think this is the right thing to do, but I'd defer it to libunwind's owner
> to approve the patch.
Removing the comment that is? Yes, since it's probably impossible to implement.
Do you have any suggestion o
ruiu added a comment.
I think this is the right thing to do, but I'd defer it to libunwind's owner to
approve the patch.
https://reviews.llvm.org/D39918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
mstorsjo created this revision.
Herald added a subscriber: aprantl.
If the linker chose to store the full section name instead of truncating it,
this field doesn't contain a truncated name, but an offset into the string
table of the binary. The string table isn't loaded/mapped into memory during
