This revision was automatically updated to reflect the committed changes.
Closed by commit rL316411: [test] Fix clang-test for FreeBSD and NetBSD
(authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D39162?vs=119803&id=119995#toc
Repository:
rL LLVM
https://reviews.llvm.
lichray added a comment.
ping?
https://reviews.llvm.org/D39162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lichray updated this revision to Diff 119803.
lichray edited the summary of this revision.
lichray added a comment.
Changed to an warning given @zturner 's comments and experiments.
https://reviews.llvm.org/D39162
Files:
test/Unit/lit.cfg.py
Index: test/Unit/lit.cfg.py
=
Because this is not tge only part of ghe library search algorithm, and it’s
not necessarily an error if the variable isn’t set
On Sun, Oct 22, 2017 at 1:56 PM Zhihao Yuan via Phabricator <
revi...@reviews.llvm.org> wrote:
> lichray marked an inline comment as done.
> lichray added a comment.
>
>
krytarowski added a comment.
In https://reviews.llvm.org/D39162#903190, @krytarowski wrote:
> In https://reviews.llvm.org/D39162#903186, @joerg wrote:
>
> > I think we should special case Darwin and Windows and fall-back to
> > LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like
lichray updated this revision to Diff 119800.
https://reviews.llvm.org/D39162
Files:
test/Unit/lit.cfg.py
Index: test/Unit/lit.cfg.py
===
--- test/Unit/lit.cfg.py
+++ test/Unit/lit.cfg.py
@@ -35,13 +35,15 @@
if symbolizer in
krytarowski added a comment.
In https://reviews.llvm.org/D39162#903186, @joerg wrote:
> I think we should special case Darwin and Windows and fall-back to
> LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like platform
> left where it doesn't work.
SHLIB_PATH in HP/UX
https:
lichray added a comment.
In https://reviews.llvm.org/D39162#903186, @joerg wrote:
> I think we should special case Darwin and Windows and fall-back to
> LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like platform
> left where it doesn't work.
If those developers come to us,
joerg added a comment.
I think we should special case Darwin and Windows and fall-back to
LD_LIBRARY_PATH for the rest. Can't remember if there is a UNIX-like platform
left where it doesn't work.
https://reviews.llvm.org/D39162
___
cfe-commits mai
lichray marked an inline comment as done.
lichray added a comment.
In https://reviews.llvm.org/D39162#903179, @zturner wrote:
> Please don't throw an exception here. Instead, write this as:
>
> lit_config.warning('Unable to determine shared library path variable for
> platform {}'.format(plat
zturner requested changes to this revision.
zturner added a comment.
This revision now requires changes to proceed.
Please don't throw an exception here. Instead, write this as:
shlibpath_var = None
if platform.system() in ['Linux', 'FreeBSD', 'NetBSD']:
shilbpath = 'LD_LIBRARY_PATH'
lichray updated this revision to Diff 119772.
lichray retitled this revision from "[test] Fix clang-test for FreeBSD" to
"[test] Fix clang-test for FreeBSD and NetBSD".
lichray edited the summary of this revision.
https://reviews.llvm.org/D39162
Files:
test/Unit/lit.cfg.py
Index: test/Unit/l
12 matches
Mail list logo
