[PATCH] D36820: [Bash-autocompletion] Add support for -std=

This revision was automatically updated to reflect the committed changes. Closed by commit rL311971: [Bash-autocompletion] Add support for -std= (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D36820?vs=111804&id=113009#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM +ping! https://reviews.llvm.org/D36820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi updated this revision to Diff 111804. yamaguchi added a comment. Update diff. Thank you for your comments! https://reviews.llvm.org/D36820 Files: clang/include/clang/Driver/Options.td clang/test/Driver/autocomplete.c llvm/utils/TableGen/OptParserEmitter.cpp Index: llvm/utils/T

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:319-320 OS << ", Values);\n"; OS << "(void)ValuesWereAdded;\nassert(ValuesWereAdded &&"; OS << " \"Couldn't add values to OptTable!\");\n"; } r

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

ruiu added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:308 const Record &R = *Opts[I]; if (!isa(R.getValueInit("ValuesCode"))) { OS << "{\n"; You can flip the condition to do early continue. Comment at

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi updated this revision to Diff 111611. yamaguchi marked 3 inline comments as done. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D36820 Files: clang/include/clang/Driver/Options.td clang/test/Driver/autocomplete.c llvm/utils/TableGen/OptParserEmitter.cpp Inde

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

ruiu added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:314 for (const std::string &Pref : R.getValueAsListOfStrings("Prefixes")) { -OS << "bool ValuesWereAdded = "; +OS << "ValuesWereAdded = "; OS << "Opt.addValues(";

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:314 for (const std::string &Pref : R.getValueAsListOfStrings("Prefixes")) { -OS << "bool ValuesWereAdded = "; +OS << "ValuesWereAdded = "; OS << "Opt.addValues(";

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi updated this revision to Diff 111549. yamaguchi marked 2 inline comments as done. yamaguchi added a comment. Update diff. https://reviews.llvm.org/D36820 Files: clang/include/clang/Driver/Options.td clang/test/Driver/autocomplete.c llvm/utils/TableGen/OptParserEmitter.cpp Inde

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

ruiu added inline comments. Comment at: clang/include/clang/Driver/Options.td:2254 + ValuesCode<[{ +const char* Values = +#define LANGSTANDARD(id, name, lang, desc, features) name "," ruiu wrote: > I think Raphael suggested indenting embedded code with at least

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

yamaguchi created this revision. Add support for autocompleting values of -std= by including LangStandards.def. This patch relies on https://reviews.llvm.org/D36782, and is using two-stage code generation. https://reviews.llvm.org/D36820 Files: clang/include/clang/Driver/Options.td clang/t