yamaguchi added inline comments.

================
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:319-320
         OS << ", Values);\n";
         OS << "(void)ValuesWereAdded;\nassert(ValuesWereAdded &&";
         OS << " \"Couldn't add values to OptTable!\");\n";
       }
----------------
ruiu wrote:
> Can you split the string after each "\n"? It seems the current way of 
> splitting is somewhat arbitrary.
Those code are on review in D36782 and I've fixed it, so I think it's fine now 
:)


https://reviews.llvm.org/D36820



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to