This revision was automatically updated to reflect the committed changes.
Closed by commit rL311569: [analyzer] Make StmtDataCollector customizable
(authored by krobelus).
Changed prior to commit:
https://reviews.llvm.org/D36664?vs=111317&id=112388#toc
Repository:
rL LLVM
https://reviews.ll
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, was on vacation.
> Since StmtDataCollectors.inc resides in lib I have to use relative paths (so
> the include directive looks different depending on the current file
johannes added a comment.
In https://reviews.llvm.org/D36664#841758, @teemperor wrote:
> Very well done, I really like this patch! I added a few remarks mostly about
> the comments that need some small adjusting.
>
> I'm wondering what would be a nice way of creating a StmtDataCollector that
>
johannes updated this revision to Diff 111317.
johannes added a subscriber: rsmith.
johannes added a comment.
add
https://reviews.llvm.org/D36664
Files:
include/clang/AST/DataCollection.h
include/clang/Analysis/CloneDetection.h
lib/AST/CMakeLists.txt
lib/AST/DataCollection.cpp
lib/AST
johannes updated this revision to Diff 111316.
johannes edited the summary of this revision.
johannes removed a subscriber: rsmith.
johannes added a comment.
- fix comments
- add unittest for the new node kinds
- make `addData()` take a const reference
https://reviews.llvm.org/D36664
Files:
i
arphaman added a subscriber: rsmith.
arphaman added a comment.
In https://reviews.llvm.org/D36664#841758, @teemperor wrote:
> Very well done, I really like this patch! I added a few remarks mostly about
> the comments that need some small adjusting.
>
> I'm wondering what would be a nice way of
teemperor added a comment.
Very well done, I really like this patch! I added a few remarks mostly about
the comments that need some small adjusting.
I'm wondering what would be a nice way of creating a StmtDataCollector that is
faster but only works for single translation units (e.g. it only ha
johannes created this revision.
Herald added subscribers: xazax.hun, mgorny.
Herald added 1 blocking reviewer(s): teemperor.
This moves the data collection macro calls for Stmt nodes
to lib/AST/StmtDataCollectors.inc
Users can subclass ConstStmtVisitor and include StmtDataCollectors.inc
to define
