[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-25 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp:389 +template +constexpr bool triviality_test = + std::is_trivially_copy_assignable>::value == `triviality_test` should also compare to an explicit

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-24 Thread Michael Park via Phabricator via cfe-commits
mpark added a comment. Yes, you're right that fine-grained SMF triviality is implemented but LWG 2904 is not yet. I would love it if you can integrate the currently `libcxx` tests into `std` tests! Thank you :) https://reviews.llvm.org/D32671 ___

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-24 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added a comment. In https://reviews.llvm.org/D32671#762840, @mpark wrote: > @CaseyCarter: Do these changes pass with the current version? > Also, have you seen the tests in > `test/libcxx/utilities/variant/variant.variant`? > If yes, do those tests and the ones in this diff overlap

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-23 Thread Michael Park via Phabricator via cfe-commits
mpark added a comment. @CaseyCarter: Does this not pass with the current version? Also, have you seen the tests in `test/libcxx/utilities/variant/variant.variant`? If yes, do those tests and the ones in this diff overlap at all? Curious as to how we should merge them. https://reviews.llvm.org/D

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-04 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97834. CaseyCarter added a comment. The constexpr variant tests were enabled separate commit (https://reviews.llvm.org/rL302158). This differential now contains only the fine-grained SMF triviality extension test. https://reviews.llvm.org/D32671 Files

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-04 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Could you commit all the changes *except* the trivial extensions tests, and then update this to contain only that? https://reviews.llvm.org/D32671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-03 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97768. CaseyCarter added a comment. Fix typos in test/std/utilities/variant/variant.variant/variant.assign/move.pass.cpp. https://reviews.llvm.org/D32671 Files: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp test/std/utilit

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-01 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97367. CaseyCarter added a comment. Fix missing indent in msvc_stdlib_force_include.hpp https://reviews.llvm.org/D32671 Files: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp test/std/utilities/variant/variant.variant/variant

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-04-29 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97204. CaseyCarter added a comment. Fix a weird corner case in variant's move assignment triviality test. https://reviews.llvm.org/D32671 Files: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp test/std/utilities/variant/varia

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-04-29 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter created this revision. NOTE: Unlike my typical `variant` test PRs, this one is actually safe to merge - crazy, I know - since it only adds coverage while testing the VC++ STL. - Define a new macro `_MSVC_STL_VER` to distinguish testing the VC++ standard library implementation in t