EricWF added inline comments.
================ Comment at: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp:389 +template<class...Ts> +constexpr bool triviality_test = + std::is_trivially_copy_assignable<std::variant<Ts...>>::value == ---------------- `triviality_test` should also compare to an explicitly specified expected result, along with checking for consistency between variant and its input types. ================ Comment at: test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp:168 +void test_triviality_extension() { +#if defined(_MSVC_STL_VER) + static_assert(triviality_test<int>, ""); ---------------- These tests pass with libc++ too, so please add `|| defined(_LIBCPP_VERSION)` ================ Comment at: test/std/utilities/variant/variant.variant/variant.ctor/move.pass.cpp:206 +void test_triviality_extension() { +#if defined(_MSVC_STL_VER) + static_assert(triviality_test<int>, ""); ---------------- These tests pass with libc++ too, so please add `|| defined(_LIBCPP_VERSION)` https://reviews.llvm.org/D32671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits