This revision was automatically updated to reflect the committed changes.
Closed by commit rL291134: [CUDA] Add __declspec spellings for CUDA attributes.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D28321?vs=83128&id=83257#toc
Repository:
rL LLVM
https://reviews.
jlebar added a comment.
Thank you for the review!
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> jlebar wrote:
> > aaron.ballman wrote:
> > > jlebar wro
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
After getting some realtime clarifications in IRC, I now understand better why
this is needed. This patch LGTM! The documentation points I raised are still
valid, but are by no m
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
jlebar wrote:
> aaron.ballman wrote:
> > jlebar wrote:
> > > aaron.ballman wrote:
> > > > For
jlebar added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> jlebar wrote:
> > aaron.ballman wrote:
> > > For my own edification, do you h
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
jlebar wrote:
> aaron.ballman wrote:
> > For my own edification, do you have a link to some d
jlebar added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> For my own edification, do you have a link to some documentation of what CUDA
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
For my own edification, do you have a link to
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: rnk, cfe-commits.
CUDA attributes are spelled __declspec(__foo__) on Windows.
https://reviews.llvm.org/D28321
Files:
clang/include/clang/Basic/Attr.td
clang/test/SemaCUDA/attr-declspec.cu
Index: clang/tes
