jlebar added inline comments.
================ Comment at: clang/include/clang/Basic/Attr.td:604 +// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__). + ---------------- aaron.ballman wrote: > For my own edification, do you have a link to some documentation of what CUDA > attributes are spelled with `__declspec`? I do not believe such documentation exists. It is an implementation detail in the CUDA headers -- users never write `__attribute__((device))` or `__declspec(__device__)`. Instead, they write `__device__`. ================ Comment at: clang/include/clang/Basic/Attr.td:610 let LangOpts = [CUDA]; let Documentation = [Undocumented]; } ---------------- aaron.ballman wrote: > Now would be a good time to add the documentation for these attributes, > otherwise there's a lot less chance users will know what ways they can spell > the attributes (or what the attribute do). See above, these are an implementation detail. https://reviews.llvm.org/D28321 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
