[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. This is done. https://reviews.llvm.org/D27773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin added a comment. I cleaned up the parameter detection and added more tests in r290352. https://reviews.llvm.org/D27773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin added a comment. In https://reviews.llvm.org/D27773#629171, @dcoughlin wrote: > I already committed this, but I'll address the feedback in a follow-on commit. I should have written "I already committed this, *so* I'll address the feedback in a follow-on commit." https://reviews.llv

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin added a comment. I already committed this, but I'll address the feedback in a follow-on commit. Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:172 +const CXXConstructorCall *Call, CheckerContext &C) const { + assert(Call->getNumArgs() > 0); + --

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

zaks.anna added a comment. Looks great overall. I have minor comments below. Thanks for the awesome comments!!! Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:152 + + ProgramStateRef State = C.getState(); + This could be moved up as you are using th

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

a.sidorin added a comment. Looks good for me, but I'm not a reviewer. Thank you Devin! Comment at: test/Driver/analyzer-target-enabled-checkers.cpp:7 // CHECK-DARWIN: "-analyzer-checker=core" +// CHECK-DARWIN-SAME: "-analyzer-checker=apiModeling" // CHECK-DARWIN-SAME: "-analy

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin updated the summary for this revision. dcoughlin updated this revision to Diff 81651. dcoughlin marked an inline comment as done. dcoughlin added a comment. Update to address Aleksei's comments. https://reviews.llvm.org/D27773 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin marked 2 inline comments as done. dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:30 +// +// The gtest unit testing API provides macros for assertions that that expand +// into an if statement that calls a series of constructors

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

a.sidorin added a comment. Thank you Devin! Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:30 +// +// The gtest unit testing API provides macros for assertions that that expand +// into an if statement that calls a series of constructors and returns "

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, NoQ. dcoughlin added subscribers: cfe-commits, alexfh, sbenza. Herald added a subscriber: mgorny. gtest is a widely-used unit-testing API provides macros for unit test assertions: ASSERT_TRUE(p != nullptr); that expand into