a.sidorin added a comment. Looks good for me, but I'm not a reviewer. Thank you Devin!
================ Comment at: test/Driver/analyzer-target-enabled-checkers.cpp:7 // CHECK-DARWIN: "-analyzer-checker=core" +// CHECK-DARWIN-SAME: "-analyzer-checker=apiModeling" // CHECK-DARWIN-SAME: "-analyzer-checker=unix" ---------------- A very minor nit/question. Do we have any convention on checker naming? Most checkers are starting with capital letters, but some not. As "API" is an abbreviation, I think we should at least start it with capital. https://reviews.llvm.org/D27773 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits