EricWF added a comment.
This patch reminds me; The way we test our containers is ridiculous. We should
have a single template that tests the container requirements, and each
container test should just use that template.
Anyway. accepting before commit.
Comment at: test/std/c
EricWF updated this revision to Diff 79007.
EricWF updated the summary for this revision.
EricWF added a comment.
Address mclows changes
https://reviews.llvm.org/D26885
Files:
.clang-format
include/__hash_table
include/__tree
include/deque
include/forward_list
include/list
include
mclow.lists added inline comments.
Comment at: test/std/containers/associative/map/map.access/max_size.pass.cpp:24
+
+template size_t alloc_max_size(Alloc const &a) {
+ typedef std::allocator_traits AT;
How about a newline here? (after the `template<>`)
And wh
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
The `max_size()` method of containers should respect both the allocator's
reported `max_size` and the range of the `difference_type`. This patch makes
all containers choose the smallest of
