EricWF added a comment.

This patch reminds me; The way we test our containers is ridiculous. We should 
have a single template that tests the container requirements, and each 
container test should just use that template.

Anyway. accepting before commit.



================
Comment at: test/std/containers/associative/map/map.access/max_size.pass.cpp:24
+
+template <class Alloc> size_t alloc_max_size(Alloc const &a) {
+  typedef std::allocator_traits<Alloc> AT;
----------------
mclow.lists wrote:
> How about a newline here? (after the `template<>`)
> 
> And why not hoist this into "test_allocator.h"?
> 
I'll change the `.clang-format` to add newlines after templates, and move this 
to test_allocator.h


https://reviews.llvm.org/D26885



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to