This revision was automatically updated to reflect the committed changes.
timshen marked an inline comment as done.
Closed by commit rL285352: [libcxx] Make regex_match backtrack when search
fails (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D26026?vs=76088&id=76109#
timshen updated this revision to Diff 76088.
timshen added a comment.
Added http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#2273 as
comments.
https://reviews.llvm.org/D26026
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp
Index: libcxx/test/st
timshen marked an inline comment as done.
timshen added inline comments.
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374
std::cmatch m;
const char s[] = "tournament";
+assert(std::regex_match(s, m, std::regex("tour|to|tournament")));
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. One minor suggestion (adding a comment to a test).
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374
std::cmatch m;
cons
timshen created this revision.
timshen added a reviewer: mclow.lists.
timshen added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
Fixes PR19851.
alg.re.match/ecma.pass.cpp still XFAILS on linux, but after commenting out
locale-related tests, it passes. I don't have a freebsd machin
