mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. One minor suggestion (adding a comment to a test).
================
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374
std::cmatch m;
const char s[] = "tournament";
+ assert(std::regex_match(s, m, std::regex("tour|to|tournament")));
----------------
I would be tempted to put a reference to http://wg21.link/LWG2273 here. (in a
comment)
https://reviews.llvm.org/D26026
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
