This revision was automatically updated to reflect the committed changes.
Closed by commit rL282470: [libc++abi] Default to DLL annotations on Windows
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24945?vs=72598&id=72599#toc
Repository:
rL LLVM
https://reviews.ll
smeenai updated this revision to Diff 72598.
smeenai added a comment.
Addressing @EricWF's comment
https://reviews.llvm.org/D24945
Files:
CMakeLists.txt
include/__cxxabi_config.h
Index: include/__cxxabi_config.h
===
--- includ
smeenai marked an inline comment as done.
smeenai added a comment.
https://reviews.llvm.org/D24945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing inline comments. Unfortunately libc++abi doesn't have a
way to make `_LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT` persistent, but this
solution works for now.
===
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
`__declspec(dllexport)` and `__declspec(dllimport)` should only be used
when building libc++abi as a DLL, but that's the more com
