EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
LGTM after addressing inline comments. Unfortunately libc++abi doesn't have a way to make `_LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT` persistent, but this solution works for now. ================ Comment at: CMakeLists.txt:255 @@ -252,1 +254,3 @@ +add_definitions(-D_LIBCXXABI_BUILDING_LIBRARY) + append_if(LIBCXXABI_COMPILE_FLAGS LIBCXXABI_HAS_WERROR_FLAG -Werror=return-type) ---------------- We probably want to define `_LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT` on Windows when `LIBCXXABI_ENABLE_SHARED=OFF` and `LIBCXXABI_ENABLE_STATIC=ON`. https://reviews.llvm.org/D24945 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
