Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-28 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:182 @@ +181,3 @@ +llvm::Expected +Replacements::mergeIfOrderIndependent(const Replacement &R) const { + Replacements Rs(R); ioeric wrote: > alexshap wrote: > > sorry, probably

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-28 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a subscriber: alexshap. Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:182 @@ +181,3 @@ +llvm::Expected +Replacements::mergeIfOrderIndependent(const Replacement &R) const { + Replacements Rs(R); sorry, probably i am late to the party, howev

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-28 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282577: Merge conflicting replacements when they are order-independent. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24800?vs=72666&id=72799#toc Repository: rL LLVM https

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-28 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Tooling/Core/Replacement.cpp:179-181 @@ +178,5 @@ +// `R` and `Replaces` are order-independent if applying them in either order +// has the same effect, so

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-27 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 72666. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D24800 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-27 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:179-181 @@ +178,5 @@ +llvm::Expected +Replacements::mergeIfOrderIndependent(const Replacement &R) const { + Replacements Rs(R); + Replacements RsShiftedByReplaces(getReplacementInChangedCode(R)); + Repla

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-27 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:179-181 @@ +178,5 @@ +llvm::Expected +Replacements::mergeIfOrderIndependent(const Replacement &R) const { + Replacements Rs(R); + Replacements RsShiftedByReplaces(getReplacementInChangedCode(R)); + Repla

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-27 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:179-181 @@ +178,5 @@ +Replacements::mergeIfOrderIndependent(const Replacement &R) const { + Replacements Rs(R); + Replacements ShiftedRs(getReplacementInChangedCode(R)); + Replacements ShiftedReplaces; +

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-27 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 72642. ioeric marked 6 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D24800 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-27 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:177-178 @@ +176,4 @@ + /// - are insertions at the same offset and applying them in either order + /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the + /// other

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-27 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:177-178 @@ +176,4 @@ + /// - are insertions at the same offset and applying them in either order + /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the + /// other

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-27 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:177-178 @@ +176,4 @@ + /// - are insertions at the same offset and applying them in either order + /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the + /// other

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-26 Thread Eric Liu via cfe-commits
ioeric added a comment. Friendly ping :) https://reviews.llvm.org/D24800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

2016-09-21 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 72045. ioeric added a comment. - Provide order-independent replacements examples in comments. https://reviews.llvm.org/D24800 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp Index: