[PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-30 Thread Aditya Kumar via cfe-commits
hiraditya added a comment. I had to revert the patch because this test case was failing. The problem was that the destructors have different return type for different targets. So I'll modify the testcase and put the patch back in. Repository: rL LLVM https://reviews.llvm.org/D24682 _

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-28 Thread Aditya Kumar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282679: [PR30341] Alias must point to a definition (authored by hiraditya). Changed prior to commit: https://reviews.llvm.org/D24682?vs=72898&id=72947#toc Repository: rL LLVM https://reviews.llvm.or

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-28 Thread Aditya Kumar via cfe-commits
hiraditya updated this revision to Diff 72898. hiraditya added a comment. Addressed Richard's comment. https://reviews.llvm.org/D24682 Files: clang/lib/CodeGen/CGCXX.cpp clang/test/CodeGenCXX/alias-available-externally.cpp Index: clang/test/CodeGenCXX/alias-available-externally.cpp ===

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-28 Thread Aditya Kumar via cfe-commits
hiraditya added inline comments. Comment at: clang/lib/CodeGen/CGCXX.cpp:169 @@ -170,3 +168,3 @@ // If we have a weak, non-discardable alias (weak, weak_odr), like an extern // template instantiation or a dllexported class, avoid forming it on COFF. Thanks

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-28 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCXX.cpp:170 @@ -170,3 +169,3 @@ // If we have a weak, non-discardable alias (weak, weak_odr), like an extern // template instantiation or a dllexported class, avoid forming it on COFF. We can no

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-28 Thread Aditya Kumar via cfe-commits
hiraditya marked 3 inline comments as done. hiraditya added a comment. https://reviews.llvm.org/D24682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-28 Thread Aditya Kumar via cfe-commits
hiraditya updated this revision to Diff 72827. hiraditya added a comment. Addressed Richard's comments. https://reviews.llvm.org/D24682 Files: clang/lib/CodeGen/CGCXX.cpp clang/test/CodeGenCXX/alias-available-externally.cpp Index: clang/test/CodeGenCXX/alias-available-externally.cpp ==

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-28 Thread Sebastian Pop via cfe-commits
sebpop added inline comments. Comment at: clang/lib/CodeGen/CGCXX.cpp:140-142 @@ +139,5 @@ + // FIXME: An extern template instantiation will create functions with + // linkage "AvailableExternally". In libc++, some classes also define + // members with attribute "AlwaysInline"

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-27 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: clang/lib/CodeGen/CGCXX.cpp:137-138 @@ -136,1 +136,4 @@ + // Disallow aliases to available_externally because available_externally + // will not be there in the end to allow the creation of the alias (PR30341). + // FIXME: An extern t

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-27 Thread Aditya Kumar via cfe-commits
hiraditya added a comment. ping! https://reviews.llvm.org/D24682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-19 Thread Sebastian Pop via cfe-commits
sebpop added a comment. The change looks good to me. Somebody else should approve. https://reviews.llvm.org/D24682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-19 Thread Aditya Kumar via cfe-commits
hiraditya marked 2 inline comments as done. hiraditya added a comment. https://reviews.llvm.org/D24682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-19 Thread Aditya Kumar via cfe-commits
hiraditya updated this revision to Diff 71827. hiraditya added a comment. Added a test case (contributed by Eric). https://reviews.llvm.org/D24682 Files: clang/lib/CodeGen/CGCXX.cpp clang/test/CodeGenCXX/alias-available-externally.cpp Index: clang/test/CodeGenCXX/alias-available-externally

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-16 Thread Sebastian Pop via cfe-commits
sebpop added inline comments. Comment at: clang/lib/CodeGen/CGCXX.cpp:137 @@ -136,1 +136,3 @@ + // r254170: Disallow aliases to available_externally. + if (TargetLinkage == llvm::GlobalValue::AvailableExternallyLinkage) Please remove the reference to r254170.

[PATCH] D24682: [PR30341] Alias must point to a definition

2016-09-16 Thread Aditya Kumar via cfe-commits
hiraditya created this revision. hiraditya added reviewers: rafael, eugenis. hiraditya added subscribers: sebpop, mclow.lists, cfe-commits, EricWF. Inlining the destructor caused the compiler to generate bad IR which failed the Verifier in the backend. https://llvm.org/bugs/show_bug.cgi?id=30341