Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-02 Thread David Blaikie via cfe-commits
On Fri, Sep 2, 2016 at 10:57 AM Aaron Ballman wrote: > aaron.ballman added inline comments. > > > Comment at: lib/Sema/SemaOverload.cpp:12996 > @@ +12995,3 @@ > + // selection expression. > + std::vector AssocExprs(GSE->getAssocExprs().vec()); > + unsigned ResultId

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-02 Thread George Burgess IV via cfe-commits
george.burgess.iv added inline comments. Comment at: lib/Sema/SemaOverload.cpp:12996 @@ +12995,3 @@ + // selection expression. + std::vector AssocExprs(GSE->getAssocExprs().vec()); + unsigned ResultIdx = GSE->getResultIndex(); aaron.ballman wrote: >

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-02 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Sema/SemaOverload.cpp:12996 @@ +12995,3 @@ + // selection expression. + std::vector AssocExprs(GSE->getAssocExprs().vec()); + unsigned ResultIdx = GSE->getResultIndex(); george.burgess.iv wrote: >

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-02 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Sema/SemaOverload.cpp:12996 @@ +12995,3 @@ + // selection expression. + std::vector AssocExprs(GSE->getAssocExprs().vec()); + unsigned ResultIdx = GSE->getResultIndex(); dblaikie wrote: > george.b

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-02 Thread David Blaikie via cfe-commits
dblaikie added inline comments. Comment at: lib/Sema/SemaOverload.cpp:12996 @@ +12995,3 @@ + // selection expression. + std::vector AssocExprs(GSE->getAssocExprs().vec()); + unsigned ResultIdx = GSE->getResultIndex(); george.burgess.iv wrote: > Is t

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-02 Thread Aaron Ballman via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r280483. https://reviews.llvm.org/D24152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-02 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. Richard accepted, so claiming this as accepted so I can close it. https://reviews.llvm.org/D24152 __

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-01 Thread Richard Smith via cfe-commits
rsmith added a comment. Lgtm other than George's nit. https://reviews.llvm.org/D24152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-01 Thread George Burgess IV via cfe-commits
george.burgess.iv added a subscriber: george.burgess.iv. george.burgess.iv added a comment. Just a drive-by nit. Thanks for the patch! Comment at: lib/Sema/SemaOverload.cpp:12996 @@ +12995,3 @@ + // selection expression. + std::vector AssocExprs(GSE->getAssocExprs().ve

[PATCH] D24152: Support the overloadable attribute with _Generic expressions

2016-09-01 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie. aaron.ballman added subscribers: cfe-commits, nemanjai. Currently, using a generic selection expression whose resulting associated expression is a function with the overloadable attribute crashes Clang. This pa