Re: [PATCH] D21301: Detect recursive default argument definition

2016-06-13 Thread Serge Pavlov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272623: Detect recursive default argument definition (authored by sepavloff). Changed prior to commit: http://reviews.llvm.org/D21301?vs=60564&id=60644#toc Repository: rL LLVM http://reviews.llvm.or

Re: [PATCH] D21301: Detect recursive default argument definition

2016-06-13 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Sema/SemaExpr.cpp:4570 @@ +4569,3 @@ + // If the default argument express

[PATCH] D21301: Detect recursive default argument definition

2016-06-13 Thread Serge Pavlov via cfe-commits
sepavloff created this revision. sepavloff added a subscriber: cfe-commits. If definition of default function argument uses itself, clang crashed, because corresponding function parameter is not associated with the default argument yet. With this fix clang emits appropriate error message. This ch