majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: lib/Sema/SemaExpr.cpp:4570 @@ +4569,3 @@ + // If the default argument expression is not set yet, we are building it now. + if (!Param->getInit()) { + Diag(Param->getLocStart(), diag::err_recursive_default_argument) << FD; ---------------- I'd make this `!Param->hasInit()`. http://reviews.llvm.org/D21301 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits