Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 marked an inline comment as done. Comment at: cfe/trunk/include/clang/Driver/Options.td:381 @@ +380,3 @@ +def cl_unsafe_math_optimizations : Flag<["-"], "cl-unsafe-math-optimizations">, Group, Flags<[CC1Option]>, + HelpText<"OpenCL only. Allow unsafe floating-point optimiz

RE: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

...@outlook.com; cfe-commits@lists.llvm.org; Liu, Yaxun (Sam) Subject: Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver jvesely added a subscriber: jvesely. Comment at: cfe/trunk/include/clang/Driver/Options.td:381 @@ +380,3 @@ +def

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

jvesely added a subscriber: jvesely. Comment at: cfe/trunk/include/clang/Driver/Options.td:381 @@ +380,3 @@ +def cl_unsafe_math_optimizations : Flag<["-"], "cl-unsafe-math-optimizations">, Group, Flags<[CC1Option]>, + HelpText<"OpenCL only. Allow unsafe floating-point optimizati

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL274150: [OpenCL] Allow -cl-std and other standard -cl- options in driver (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D21031?vs=61574&id=62267#toc Repository: rL LLVM http:

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! http://reviews.llvm.org/D21031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 updated this revision to Diff 61574. ashi1 marked 4 inline comments as done. ashi1 added a comment. Revised to Anastasia's comments. http://reviews.llvm.org/D21031 Files: include/clang/Basic/DiagnosticFrontendKinds.td include/clang/Driver/CC1Options.td include/clang/Driver/Options.t

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

Anastasia added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1673 @@ +1672,3 @@ + // this option was added for compatibility with OpenCL 1.0. + if (const Arg *A = Args.getLastArg(OPT_cl_strict_aliasing)) { +const int OpenCLVer = Opts.OpenCLVersion; --

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 updated this revision to Diff 61423. ashi1 marked 2 inline comments as done. ashi1 added a comment. Revised based on Anastasia's comments. Also clang-test run passes, the testcases should be working correctly. http://reviews.llvm.org/D21031 Files: include/clang/Basic/DiagnosticFrontend

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:220 @@ +219,2 @@ +def warn_option_depre_ocl_version : Warning< + "Option %0 is deprecated for this OpenCL version">, InGroup; Looks good. If we could output the current O

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 updated this revision to Diff 61275. ashi1 marked 2 inline comments as done. ashi1 added a comment. Revised with Anastasia's comments. Please take a look at the diagnostic to see if it is what we want. http://reviews.llvm.org/D21031 Files: include/clang/Basic/DiagnosticFrontendKinds.td

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 marked 6 inline comments as done. ashi1 added a comment. F2085685: D21031.patch Comment at: include/clang/Driver/CC1Options.td:670 @@ -669,21 +669,3 @@ -def cl_opt_disable : Flag<["-"], "cl-opt-disable">, - HelpText<"OpenCL only. This

Re: [PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

Anastasia added inline comments. Comment at: include/clang/Driver/CC1Options.td:670 @@ -669,21 +669,3 @@ -def cl_opt_disable : Flag<["-"], "cl-opt-disable">, - HelpText<"OpenCL only. This option disables all optimizations. The default is optimizations are enabled.">; -def cl_s

[PATCH] D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver

ashi1 created this revision. ashi1 added a reviewer: Anastasia. ashi1 added subscribers: yaxunl, cfe-commits, pxli168, bader, rsmith, nhaustov. Allow -cl-std and other standard -cl- options from cc1 to driver. Added a test for the options moved. http://reviews.llvm.org/D21031 Files: include/c