Anastasia added inline comments. ================ Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:220 @@ +219,2 @@ +def warn_option_depre_ocl_version : Warning< + "Option %0 is deprecated for this OpenCL version">, InGroup<Deprecated>; ---------------- Looks good. If we could output the current OpenCL version as well to match the diagnostic style from http://reviews.llvm.org/D19780, it would be nice.
================ Comment at: test/Driver/opencl.cl:32 @@ -14,2 +31,3 @@ +// CHECK-DENORMS-ARE-ZERO: .*clang.* "-cc1" .* "-cl-denorms-are-zero" kernel void func(void); ---------------- Could you also test the new diagnostic message you are adding please? http://reviews.llvm.org/D21031 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
