EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting after speaking to @compnerd.
http://reviews.llvm.org/D20886
___
cfe-commits mailing list
cfe-commits@l
EricWF added inline comments.
Comment at: CMakeLists.txt:201
@@ +200,3 @@
+ message(FATAL_ERROR "LIBCXXABI_BUILD_32_BITS=ON is not supported on this
platform.")
+endif()
+
Done in r271462.
http://reviews.llvm.org/D20886
_
EricWF added inline comments.
Comment at: CMakeLists.txt:201
@@ +200,3 @@
+ message(FATAL_ERROR "LIBCXXABI_BUILD_32_BITS=ON is not supported on this
platform.")
+endif()
+
compnerd wrote:
> Why not handle this like libunwind? Alternative, we could duplicate thi
EricWF updated this revision to Diff 59327.
EricWF marked an inline comment as done.
EricWF added a comment.
Address review comments
- Add '=' in sysroot flag.
http://reviews.llvm.org/D20886
Files:
CMakeLists.txt
test/CMakeLists.txt
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
=
compnerd added inline comments.
Comment at: CMakeLists.txt:201
@@ +200,3 @@
+ message(FATAL_ERROR "LIBCXXABI_BUILD_32_BITS=ON is not supported on this
platform.")
+endif()
+
Why not handle this like libunwind? Alternative, we could duplicate this into
libunwin
EricWF updated this revision to Diff 59308.
EricWF added a comment.
Add missing declaration for `LIBCXXABI_TARGET_TRIPLE` option.
http://reviews.llvm.org/D20886
Files:
CMakeLists.txt
test/CMakeLists.txt
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
EricWF created this revision.
EricWF added reviewers: danalbert, jroelofs, bcraig, compnerd.
EricWF added a subscriber: cfe-commits.
This patch changes the libc++abi CMake so that it adds certain target flags
like '-m32' or '--gcc-toolchain' before including `config-ix.cmake`.
Since these flags
