compnerd added inline comments.
================
Comment at: CMakeLists.txt:201
@@ +200,3 @@
+ message(FATAL_ERROR "LIBCXXABI_BUILD_32_BITS=ON is not supported on this
platform.")
+endif()
+
----------------
Why not handle this like libunwind? Alternative, we could duplicate this into
libunwind. But we should behave similarly across the two I think.
================
Comment at: CMakeLists.txt:219
@@ +218,3 @@
+ list(APPEND LIBCXXABI_LINK_FLAGS ${var})
+endmacro()
+
----------------
No CMAKE_LINKER_FLAGS like libunwind/libc++?
================
Comment at: CMakeLists.txt:233
@@ +232,3 @@
+add_target_flags_if(LIBCXXABI_SYSROOT
+ "--sysroot ${LIBCXXABI_SYSROOT}")
+
----------------
This should be "--sysroot=${LIBCXXABI_SYSROOT}"
http://reviews.llvm.org/D20886
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
