hfinkel abandoned this revision.
hfinkel added a comment.
Abandoned in favor of
https://reviews.llvm.org/D25225/https://reviews.llvm.org/D25262.
https://reviews.llvm.org/D19678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rjmccall added a comment.
In http://reviews.llvm.org/D19678#420358, @hfinkel wrote:
> In http://reviews.llvm.org/D19678#419445, @rjmccall wrote:
>
> > This discussion of the command line interface makes me think that we should
> > be taking Richard's suggestion one step further. Why is Clang's
hfinkel added a comment.
In http://reviews.llvm.org/D19678#419445, @rjmccall wrote:
> This discussion of the command line interface makes me think that we should
> be taking Richard's suggestion one step further. Why is Clang's involvement
> here more than just handing down specific requests f
rjmccall added a comment.
This discussion of the command line interface makes me think that we should be
taking Richard's suggestion one step further. Why is Clang's involvement here
more than just handing down specific requests for optimization data to LLVM and
packaging that information back
hfinkel added a comment.
In http://reviews.llvm.org/D19678#419361, @rcox2 wrote:
> Of course, it would be my preference to mirror the functionality of what is
> available in the "new" hierarchical form of optimization report Intel
> compiler. So, I would like to distinguish between what Hal is
rcox2 added a comment.
Of course, it would be my preference to mirror the functionality of what is
available in the "new" hierarchical form of optimization report Intel compiler.
So, I would like to distinguish between what Hal is proposing (which we call
an "annotated listing") and what I am
On Mon, May 2, 2016 at 4:14 PM, Hal Finkel via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> hfinkel added a comment.
>
> In http://reviews.llvm.org/D19678#416127, @rcox2 wrote:
>
> > Actually, the Intel compiler distinguishes between an optimization
> report (-qopt-report) and an annotated l
hfinkel added a comment.
In http://reviews.llvm.org/D19678#416127, @rcox2 wrote:
> Actually, the Intel compiler distinguishes between an optimization report
> (-qopt-report) and an annotated listing (-qopt-report-annotate). The
> optimization report lists the info for optimizations in a hierar
hfinkel updated this revision to Diff 55907.
hfinkel added a comment.
Renamed the option from -flisting to -foptimization-report as suggested. Moved
I/O-related and formatting-related code into Frontend.
http://reviews.llvm.org/D19678
Files:
include/clang/Driver/CC1Options.td
include/clang
hfinkel added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:734-737
@@ +733,6 @@
+
+ OS << llvm::format_decimal(L + 1, LNDigits) << " ";
+ OS << (LLI.Inlined.Transformed && InlinedCols < 2 ? "I" : " ");
+ OS << (LLI.Unrolled.Transformed && UnrolledCols
hfinkel added a comment.
In http://reviews.llvm.org/D19678#416039, @hfinkel wrote:
> In http://reviews.llvm.org/D19678#415902, @rsmith wrote:
>
> > You give this example:
> >
> > > 343 | Loc = ConvertBackendLocation(D,
> > > Context->getSourceManager());
> >
> > > I |
anemet added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:734-737
@@ +733,6 @@
+
+ OS << llvm::format_decimal(L + 1, LNDigits) << " ";
+ OS << (LLI.Inlined.Transformed && InlinedCols < 2 ? "I" : " ");
+ OS << (LLI.Unrolled.Transformed && UnrolledCols <
hfinkel added a comment.
In http://reviews.llvm.org/D19678#416127, @rcox2 wrote:
> Actually, the Intel compiler distinguishes between an optimization report
> (-qopt-report) and an annotated listing (-qopt-report-annotate).
Interesting; thanks for pointing this out (and for the example).
>
rcox2 added a comment.
Actually, the Intel compiler distinguishes between an optimization report
(-qopt-report) and an annotated listing (-qopt-report-annotate). The
optimization report lists the info for optimizations in a hierarchical fashion.
To use you example,
icc -c -O3 -qopt-report=
rjmccall added a comment.
In http://reviews.llvm.org/D19678#416059, @hfinkel wrote:
> In http://reviews.llvm.org/D19678#415844, @rjmccall wrote:
>
> > I see what you're going for with "listing file", but I like ICC's option
> > name much better, or at least something along those lines.
>
>
> Sou
hfinkel added a comment.
In http://reviews.llvm.org/D19678#415844, @rjmccall wrote:
> I see what you're going for with "listing file", but I like ICC's option name
> much better, or at least something along those lines.
Sounds good to me. Do you have a preference on -fopt-report vs.
-foptimiz
hfinkel added a comment.
In http://reviews.llvm.org/D19678#415902, @rsmith wrote:
> You give this example:
>
> > 343 | Loc = ConvertBackendLocation(D,
> > Context->getSourceManager());
>
> > I | ^
>
> > I | ^
>
>
> How does
rsmith added a comment.
You give this example:
> 343 | Loc = ConvertBackendLocation(D, Context->getSourceManager());
> I | ^
> I | ^
How does this look for a case like `p->Foo()->Bar()` (where one or both of the
calls ar
hfinkel added a comment.
> My primary inspiration here is the reports generated by Cray's tools
> (http://docs.cray.com/books/S-2496-4101/html-S-2496-4101/z1112823641oswald.html).
http://docs.cray.com/books/S-2315-52/html-S-2315-52/fixedds0jdeh38.html is a
better link.
http://reviews.llvm.or
rjmccall added a comment.
I see what you're going for with "listing file", but I like ICC's option name
much better, or at least something along those lines.
http://reviews.llvm.org/D19678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
hfinkel created this revision.
hfinkel added reviewers: rsmith, chandlerc, rcox2, jmolloy, anemet,
silviu.baranga, mzolotukhin, spatel, rengolin, delena, Carrot, congh, echristo.
hfinkel added a subscriber: cfe-commits.
Herald added subscribers: joker.eph, mcrosier.
This patch implements support
21 matches
Mail list logo
