Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-06-16 Thread Andrey Turetskiy via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272883: Compilation for Intel MCU (Part 2/3) (authored by aturetsk). Changed prior to commit: http://reviews.llvm.org/D19274?vs=57017&id=60958#toc Repository: rL LLVM http://reviews.llvm.org/D19274

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-06-15 Thread Bruno Cardoso Lopes via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Sure! LGTM http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-06-15 Thread Andrey Turetskiy via cfe-commits
aturetsk added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + aturetsk wrote: > bruno wrote: > > aturetsk wr

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-26 Thread Andrey Turetskiy via cfe-commits
aturetsk added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + bruno wrote: > aturetsk wrote: > > bruno wrote

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-26 Thread Bruno Cardoso Lopes via cfe-commits
bruno added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + aturetsk wrote: > bruno wrote: > > Taking a look

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-26 Thread Andrey Turetskiy via cfe-commits
aturetsk added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + bruno wrote: > Taking a look at this again I d

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-25 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. Hi, Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + Taking a look at this again I don't think there's

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-25 Thread Andrey Turetskiy via cfe-commits
aturetsk added a comment. Ping. http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-12 Thread Andrey Turetskiy via cfe-commits
aturetsk added a comment. Hi Bruno, Thanks for the review. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:157 @@ -156,1 +156,3 @@ +def err_drv_cxx_not_supported : Error< + "C++ is not supported for target '%0'">; Yes. I've found nothing similar. ==

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-12 Thread Andrey Turetskiy via cfe-commits
aturetsk updated this revision to Diff 57017. aturetsk added a comment. Fix the remarks. http://reviews.llvm.org/D19274 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/D

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-11 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. Hi, Comment at: include/clang/Basic/DiagnosticDriverKinds.td:154 @@ -153,1 +153,3 @@ +def err_drv_cxx_not_supported : Error< + "C++ is not supported for target '%0'">; Are you sure there's no equivalente for this already? I'm surprised!

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-05-11 Thread Andrey Turetskiy via cfe-commits
aturetsk added a comment. Ping. http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-04-20 Thread Andrey Turetskiy via cfe-commits
aturetsk added a comment. Hi Mandeep, Thanks for the review. Comment at: lib/Driver/ToolChains.cpp:2153 @@ -2148,1 +2152,3 @@ + FilterNonExistent NonExistent( + Path, TargetTriple.isOSIAMCU() ? "/libgcc.a" : "/crtbegin.o", D.getVFS()); Does anybody know

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-04-20 Thread Andrey Turetskiy via cfe-commits
aturetsk updated this revision to Diff 54341. aturetsk added a comment. Fixed the remarks. http://reviews.llvm.org/D19274 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-04-19 Thread Mandeep Singh Grang via cfe-commits
mgrang added a subscriber: mgrang. Comment at: lib/Driver/Tools.cpp:580 @@ -573,1 +579,3 @@ + if (IsIAMCU) +getToolChain().AddIAMCUIncludeArgs(Args, CmdArgs); } Is it better to move this above in the else part of the condition "if (!IsIAMCU)"?

[PATCH] D19274: Compilation for Intel MCU (Part 2/3)

2016-04-19 Thread Andrey Turetskiy via cfe-commits
aturetsk created this revision. aturetsk added reviewers: rsmith, bruno, bkramer. aturetsk added subscribers: cfe-commits, DavidKreitzer, zinovy.nis. This is the second patch required to support compilation for Intel MCU target (e.g. Intel(R) Quark(TM) micro controller D 2000). When IAMCU triple