mgrang added a subscriber: mgrang. ================ Comment at: lib/Driver/Tools.cpp:580 @@ -573,1 +579,3 @@ + if (IsIAMCU) + getToolChain().AddIAMCUIncludeArgs(Args, CmdArgs); } ---------------- Is it better to move this above in the else part of the condition "if (!IsIAMCU)"?
================ Comment at: lib/Driver/Tools.cpp:3625 @@ +3624,3 @@ + // C++ is not supported for IAMCU. + if(IsIAMCU && types::isCXX(Input.getType())) + D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); ---------------- nitpick: Missing space between if and ( http://reviews.llvm.org/D19274 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
