Re: [PATCH] D19254: Implement P0033R1 - Re-enabling shared_from_this

2016-06-01 Thread Eric Fiselier via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271449: Implement P0033R1 - Re-enabling shared_from_this (authored by EricWF). Changed prior to commit: http://reviews.llvm.org/D19254?vs=54150&id=59316#toc Repository: rL LLVM http://reviews.llvm.o

Re: [PATCH] D19254: Implement P0033R1 - Re-enabling shared_from_this

2016-06-01 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. Other than the versioning, this looks fine to me. Comment at: include/memory:5439 @@ -5438,1 +5438,3 @@ +_LIBCPP_INLINE_VISIBILITY +weak_ptr<_Tp> weak_from_this() _NOEXCEPT Shouldn't these be wrapped in `#ifdef _LIBCPP_VER

[PATCH] D19254: Implement P0033R1 - Re-enabling shared_from_this

2016-04-18 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0033r1.html http://reviews.llvm.org/D19254 Files: include/memory test/std/utilities/memory/util.smartptr/util.smartptr.ena