mclow.lists added a comment.
Other than the versioning, this looks fine to me.
================
Comment at: include/memory:5439
@@ -5438,1 +5438,3 @@
+ _LIBCPP_INLINE_VISIBILITY
+ weak_ptr<_Tp> weak_from_this() _NOEXCEPT
----------------
Shouldn't these be wrapped in `#ifdef _LIBCPP_VER > 14` ?
================
Comment at:
test/std/utilities/memory/util.smartptr/util.smartptr.enab/enable_shared_from_this.pass.cpp:59
@@ -52,1 +58,3 @@
}
+ // Test weak_from_this_methods
+ {
----------------
These too - C++17 only?
http://reviews.llvm.org/D19254
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
