alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
This test doesn't fail without your fix.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:155
@@ -155,1 +154,3 @@
+.bind("Initializer")),
+
Kessoufi updated this revision to Diff 54762.
Kessoufi added a comment.
- my previous fix was applied on the wrong location and accidentally worked.
now applied on the right location
- previous tests still pass
- added a specific test to highlight my issue
http://reviews.llvm.org/D19194
Files
alexfh added a comment.
Now the problem is that the check changed behavior, but the tests are not
updated. Do the tests still pass? If yes, we need to add tests for this
behavior. If no, please fix the tests.
http://reviews.llvm.org/D19194
___
cfe
Kessoufi marked an inline comment as done.
Kessoufi added a comment.
Done
http://reviews.llvm.org/D19194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Kessoufi updated this revision to Diff 54524.
Kessoufi added a comment.
removed the redundant matcher
http://reviews.llvm.org/D19194
Files:
clang-tidy/modernize/PassByValueCheck.cpp
Index: clang-tidy/modernize/PassByValueCheck.cpp
=
alexfh added a subscriber: alexfh.
alexfh requested changes to this revision.
alexfh added a reviewer: alexfh.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:166
@@ -150,3 +165,3 @@
hasDeclaration(cxxCo
