hintonda added a comment.
Will do -- moved and started new job, so got a bit behind.
Btw, I have a new checker that's under review that will take care of the
noexcept for you. And I think someone else has something that might take care
of the implicit copy/assignment.
So this should be trivia
mclow.lists added a comment.
Let's retire this patch, then.
I'll be watching for your replacement patches.
http://reviews.llvm.org/D18217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
hintonda added a comment.
Yes, those were mostly in comments. I'd just done a simple find/grep that
didn't take context into account.
I agree that multiple checkins would be best which will make it much easy to
review.
http://reviews.llvm.org/D18217
___
mclow.lists added a comment.
One idea is to do this in two steps - do the `throw()` stuff in one patch, and
the defaulted fns in a second one.
http://reviews.llvm.org/D18217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
mclow.lists added a comment.
> Okay, but should I fix the 146 cases of " = default;" that were already there?
If there are `= default` in code that can be used from C++03, then they ought
to be fixed.
Note that many of the ones that turn up in a text search are in the synopsis -
not in the cod
hintonda added a comment.
Okay, but should I fix the 146 cases of " = default;" that were already there?
That's a lot of churn, so I don't want to step on anyone...
http://reviews.llvm.org/D18217
___
cfe-commits mailing list
cfe-commits@lists.llvm
mclow.lists added inline comments.
Comment at: include/__bit_reference:75
@@ -73,1 +74,3 @@
+_LIBCPP_INLINE_VISIBILITY
+__bit_reference(const __bit_reference&) _NOEXCEPT = default;
private:
Sadly, we don't get to say '=default', because we have clients th
Just to clarify, they are deprecated with an explicit dtor's are provided.
On Sat, Mar 19, 2016 at 11:26 AM, don hinton wrote:
> hintonda added a comment.
>
> Implicit copy ctor's and and assignment operators are deprecated in c++11,
> which is why I added them as = default, but you raise a good
hintonda added a comment.
Implicit copy ctor's and and assignment operators are deprecated in c++11,
which is why I added them as = default, but you raise a good point. Perhaps it
would be better to wrap them in #ifdef's.
http://reviews.llvm.org/D18217
_
logan added a subscriber: logan.
logan added a comment.
The simple replacement from `throw()` to `_NOEXCEPT` looks fine.
But, why are you adding adding some copy constructors and assignment operators?
May you briefly explain the reason?
Besides, I have some concern with the `= default` specifi
hintonda created this revision.
hintonda added reviewers: rsmith, howard.hinnant, logan.
hintonda added a subscriber: cfe-commits.
Fix -Wdeprecated warning for throw() specs and implicit copy
ctor's and assignmen oper's.
http://reviews.llvm.org/D18217
Files:
include/__bit_reference
include/_
11 matches
Mail list logo
