bcraig closed this revision.
bcraig added a comment.
r270213
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
I'll be submitting this Friday morning, barring any objections (I'm out of the
office the next couple of days).
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
bcraig updated this revision to Diff 57521.
bcraig marked 2 inline comments as done.
http://reviews.llvm.org/D17416
Files:
include/support/android/locale_bionic.h
include/support/newlib/xlocale.h
include/support/xlocale/__posix_l_fallback.h
include/support/xlocale/__strtonum_fallback.h
bcraig updated this revision to Diff 57520.
http://reviews.llvm.org/D17416
Files:
include/support/android/locale_bionic.h
include/support/newlib/xlocale.h
include/support/xlocale/__posix_l_fallback.h
include/support/xlocale/__strtonum_fallback.h
include/support/xlocale/xlocale.h
Index:
danalbert accepted this revision.
danalbert added a comment.
This revision is now accepted and ready to land.
LGTM. Sorry for the delay in response.
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
mclow.lists added a comment.
A couple of packaging comments. In general, this looks fine to me - still
waiting on someone from Android to chime in. -- I'll ping Dan.
Comment at: include/support/xlocale/__posix_l_fallback.h:13
@@ +12,3 @@
+// extended locale support for libc's
bcraig added a comment.
ping @danalbert, @mclow.lists
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping @danalbert, @mclow.lists
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping @danalbert
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
This looks fine to me; but I want to hear from @danalbert.
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 2/19/2016 8:40 AM, Joerg Sonnenberger via cfe-commits wrote:
On Thu, Feb 18, 2016 at 10:32:11PM +, Ben Craig via cfe-commits wrote:
The fallback locale functions are also useful on their own for other
lightweight platforms. Putting these fallback implementations in
support/xlocale should
On Thu, Feb 18, 2016 at 10:32:11PM +, Ben Craig via cfe-commits wrote:
> The fallback locale functions are also useful on their own for other
> lightweight platforms. Putting these fallback implementations in
> support/xlocale should enable code sharing.
Shouldn't the fallback functions be usi
bcraig created this revision.
bcraig added reviewers: jroelofs, danalbert, mclow.lists.
bcraig added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, jfb.
This is one part of many of a locale refactor. See
http://reviews.llvm.org/D17146 for an idea of where th
13 matches
Mail list logo
