On 2/19/2016 8:40 AM, Joerg Sonnenberger via cfe-commits wrote:
On Thu, Feb 18, 2016 at 10:32:11PM +0000, Ben Craig via cfe-commits wrote:
The fallback locale functions are also useful on their own for other
lightweight platforms. Putting these fallback implementations in
support/xlocale should enable code sharing.
Shouldn't the fallback functions be using uselocale() when available?

Joerg
Soon, yes. This change is just moving functions from one header to another. Doing a move + significant change is painful to review... but you can see some of where that is going in this now-defunct review:
http://reviews.llvm.org/D17146

I fully intend on making each of the fallback functions call one of the uselocale RAII objects. I would need to ensure that the RAII object inlined away on platforms without extended locale support.

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux 
Foundation Collaborative Project

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to