Re: [PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-04-18 Thread Ben Craig via cfe-commits
bcraig closed this revision. bcraig added a comment. r266611 http://reviews.llvm.org/D17410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-04-18 Thread Ben Craig via cfe-commits
bcraig added a comment. In http://reviews.llvm.org/D17410#403263, @EricWF wrote: > So we already do this for the standalone builds but not for in-tree builds. > Before committing please make sure to remove the code on CMakeLists.txt line > 99 that does this same thing. Done > I'm assuming c

Re: [PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-04-15 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. So we already do this for the standalone builds but not for in-tree builds. Before committing please make sure to remove the code on CMakeLists.txt line 99 that does this same thing. I'm assu

Re: [PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-03-29 Thread Ben Craig via cfe-commits
bcraig added a comment. ping http://reviews.llvm.org/D17410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-03-09 Thread Ben Craig via cfe-commits
bcraig added a comment. ping http://reviews.llvm.org/D17410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-02-18 Thread Ben Craig via cfe-commits
bcraig updated this revision to Diff 48396. bcraig added a comment. Prior version doesn't apply to master. The context was dirty from some unsubmitted patches. http://reviews.llvm.org/D17410 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D17410: [libcxxabi] Respect LIBCXXABI_LIBDIR_SUFFIX before an install

2016-02-18 Thread Ben Craig via cfe-commits
bcraig created this revision. bcraig added reviewers: mclow.lists, EricWF, danalbert, jroelofs. bcraig added a subscriber: cfe-commits. Prior to this patch, setting LIBCXXABI_LIBDIR_SUFFIX would confuse the check-libcxxabi target. libc++abi.* would get output to lib instead of lib${LIBCXXABI_LI