EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

So we already do this for the standalone builds but not for in-tree builds. 
Before committing please make sure to remove the code on CMakeLists.txt line 99 
that does this same thing.

I'm assuming changing these CMake variables doesn't propagate upwards to other 
in-tree projects?

My one concern is that libc++ won't be able to find libc++abi when it's in a 
custom directory.
But that shouldn't cause problems unless it's made to.

After all that this LGTM.


http://reviews.llvm.org/D17410



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to