Re: [PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

2016-03-29 Thread Hrvoje Varga via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264727: Add additional Hi/Lo registers to Clang MipsTargetInfoBase (authored by hvarga). Changed prior to commit: http://reviews.llvm.org/D17378?vs=48309&id=51893#toc Repository: rL LLVM http://revi

Re: [PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

2016-03-29 Thread Daniel Sanders via cfe-commits
dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM Sorry for missing this when it was first posted. I've also been away for roughly half of the two weeks since Petar added me to the review. http://reviews.llvm.org/D17378

Re: [PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

2016-03-28 Thread Chandler Carruth via cfe-commits
chandlerc added a comment. I don't know anything about MIPS and this seems a highly MIPS specific change, so I can't provide any useful review here. You have someone with MIPS specific knowledge on the review though, so you seem to have the appropriate people looped in... http://reviews.llvm.

Re: [PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

2016-03-22 Thread Hrvoje Varga via cfe-commits
hvarga added a comment. Are there any thoughts about this patch? http://reviews.llvm.org/D17378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

2016-02-18 Thread Hrvoje Varga via cfe-commits
hvarga added a comment. I'm not sure if I added all of the necessary reviewers or even the correct ones. So please feel free to correct this if it's wrong. http://reviews.llvm.org/D17378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D17378: Add additional Hi/Lo registers to Clang MipsTargetInfoBase

2016-02-18 Thread Hrvoje Varga via cfe-commits
hvarga created this revision. hvarga added reviewers: hfinkel, atrick, chandlerc. hvarga added subscribers: cfe-commits, petarj. This patch fixes bug https://dmz-portal.mips.com/bugz/show_bug.cgi?id=2300 by adding additional (missing) Hi/Lo registers to the Clang `MipsTargetInfoBase` class. htt