aaron.ballman closed this revision.
aaron.ballman added a comment.
For cleanliness. ;-)
http://reviews.llvm.org/D15958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
For posterity :)
http://reviews.llvm.org/D15958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
aaron.ballman added a comment.
Good catches! I've fixed those issues, and commit in r257097 (I thought I had
the LG, but now notice I don't -- if this is a problem, I will revert).
http://reviews.llvm.org/D15958
___
cfe-commits mailing list
cfe-com
rsmith added a comment.
Thanks!
You also need to update ASTWriterDecl.cpp's construction of
`CharacterLiteralAbbrev` to allow three bits of `Kind` rather than two. (You
should be able to repro this with a PCH test pretty-printing a `U'x'` literal.)
Comment at: lib/Sema/SemaTe
