rsmith added a comment.

Thanks!

You also need to update ASTWriterDecl.cpp's construction of 
`CharacterLiteralAbbrev` to allow three bits of `Kind` rather than two. (You 
should be able to repro this with a PCH test pretty-printing a `U'x'` literal.)


================
Comment at: lib/Sema/SemaTemplate.cpp:5507
@@ -5506,1 +5506,3 @@
+    // This does not need to handle u8 character literals because those are
+    // of type char, and so can also be covered by an Ascii character literal.
     CharacterLiteral::CharacterKind Kind;
----------------
Ascii -> ASCII


http://reviews.llvm.org/D15958



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to