Re: [PATCH] D15928: Add -Wfor-loop-analysis to -Wall.

2016-01-06 Thread Nico Weber via cfe-commits
thakis closed this revision. thakis added a comment. r256975, thanks! http://reviews.llvm.org/D15928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15928: Add -Wfor-loop-analysis to -Wall.

2016-01-06 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. LGTM as well, FWIW http://reviews.llvm.org/D15928 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D15928: Add -Wfor-loop-analysis to -Wall.

2016-01-06 Thread Richard Trieu via cfe-commits
rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. LGTM The most complex things these warnings use is an AST visitor, so the compile time impact should be minimal. http://reviews.llvm.org/D15928 ___

[PATCH] D15928: Add -Wfor-loop-analysis to -Wall.

2016-01-06 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added a reviewer: rtrieu. thakis added a subscriber: cfe-commits. Every time I try this warning, it finds a few bugs (I think about 4 total in Chromium so far), with 0 false positives. I couldn't measure any build performance degradation when turning it on; I