thakis created this revision.
thakis added a reviewer: rtrieu.
thakis added a subscriber: cfe-commits.

Every time I try this warning, it finds a few bugs (I think about 4 total in 
Chromium so far), with 0 false positives. I couldn't measure any build 
performance degradation when turning it on; I tried building clang itself with 
and without the warning, and a small-ish target in chromium (1.6k TUs).

It should be in -Wall, and possibly even make its way into a default warning at 
some point.

http://reviews.llvm.org/D15928

Files:
  include/clang/Basic/DiagnosticGroups.td

Index: include/clang/Basic/DiagnosticGroups.td
===================================================================
--- include/clang/Basic/DiagnosticGroups.td
+++ include/clang/Basic/DiagnosticGroups.td
@@ -616,6 +616,7 @@
     CharSubscript,
     Comment,
     DeleteNonVirtualDtor,
+    ForLoopAnalysis,
     Format,
     Implicit,
     InfiniteRecursion,


Index: include/clang/Basic/DiagnosticGroups.td
===================================================================
--- include/clang/Basic/DiagnosticGroups.td
+++ include/clang/Basic/DiagnosticGroups.td
@@ -616,6 +616,7 @@
     CharSubscript,
     Comment,
     DeleteNonVirtualDtor,
+    ForLoopAnalysis,
     Format,
     Implicit,
     InfiniteRecursion,
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to