Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-02-11 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. In http://reviews.llvm.org/D15920#350401, @beanz wrote: > Can you commit the test changes in a separate commit before committing the > other changes? That way if something goes wrong the diff for the meat of the > patch is a small diff. Committed seperately in http:/

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-02-11 Thread Jonas Hahnfeld via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260662: [CMake] Add option to switch default C++ stdlib (authored by Hahnfeld). Changed prior to commit: http://reviews.llvm.org/D15920?vs=47441&id=47770#toc Repository: rL LLVM http://reviews.llvm.

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-02-11 Thread Chris Bieneman via cfe-commits
beanz added a comment. Everything about this looks reasonable to me. Can you commit the test changes in a separate commit before committing the other changes? That way if something goes wrong the diff for the meat of the patch is a small diff. http://reviews.llvm.org/D15920 ___

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-02-10 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld marked an inline comment as done. Hahnfeld added a comment. In http://reviews.llvm.org/D15920#347352, @beanz wrote: > Is it correct to assume that all the test case changes are needed just to > make the tests pass if you set CLANG_DEFAULT_CXX_STDLIB=libc++? > > [...] Yes, most of the

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-02-10 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld updated this revision to Diff 47441. Hahnfeld added a comment. Address reviewers' comments: - check for valid `CLANG_DEFAULT_CXX_STDLIB` - generalize for `Darwin` and `Bitrig` by introducing `GetDefaultCXXStdlibType` - fallback to `CLANG_DEFAULT_CXX_STDLIB` if user choice is incorrect

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-02-09 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. The direction here generally seems fine to me. Comment at: lib/Driver/ToolChain.cpp:538 @@ -536,7 +537,3 @@ ToolChain::CXXStdlibType ToolChain::GetCXXStdlibType(const ArgList &Args) const{ - if (Arg *A = Args.getLastA

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-02-09 Thread Chris Bieneman via cfe-commits
beanz added a comment. Is it correct to assume that all the test case changes are needed just to make the tests pass if you set CLANG_DEFAULT_CXX_STDLIB=libc++? I'm not really comfortable approving this patch because I've made all of one or two changes ever to the driver, but I can try to peste

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-02-09 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. ping http://reviews.llvm.org/D15920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-01-27 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a reviewer: mcrosier. Hahnfeld added a comment. Any comments on this change? http://reviews.llvm.org/D15920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15920: [CMake] Add option to switch default C++ stdlib

2016-01-06 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld created this revision. Hahnfeld added reviewers: chandlerc, mclow.lists, beanz. Hahnfeld added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. With this option one can set the default library to use if no `-stdlib=` is provided on compiler invocation