beanz added a comment. Is it correct to assume that all the test case changes are needed just to make the tests pass if you set CLANG_DEFAULT_CXX_STDLIB=libc++?
I'm not really comfortable approving this patch because I've made all of one or two changes ever to the driver, but I can try to pester someone else to take a gander. It doesn't look particularly invasive to me. One comment inline. ================ Comment at: lib/Driver/ToolChain.cpp:552 @@ -546,3 +551,3 @@ return ToolChain::CST_Libstdcxx; } ---------------- There are two cases where this line would get hit: (1) If the stdlib arg is an invalid library, it falls through here after printing the diagnostic (2) if CLANG_DEFAULT_CXX_STDLIB is itself an invalid library value Can you add a configure-time or compile time check to catch case 2? http://reviews.llvm.org/D15920 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
