This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
nridge marked an inline comment as done.
Closed by commit rG8ee710a40cc5: [clangd] Parameter hints for calls through
function pointers (authored by nridge).
Repository
nridge marked an inline comment as done.
nridge added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:508
+ // Only one of Callee or ProtoTypeLoc is set.
+ const FunctionDecl *Callee = nullptr;
+ FunctionProtoTypeLoc ProtoTypeLoc;
sammccal
nridge updated this revision to Diff 551696.
nridge added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158249/new/
https://reviews.llvm.org/D158249
Files:
clang-tools-extra/clangd/InlayHints.cpp
clang-tools-
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:466
+// so that we can recover argument names from it.
+// FIXME: This function is mostly duplicated in SemaCodeComplete.cpp; unify.
+static FunctionProtoTypeLoc getPrototypeLoc(Expr *Callee) {
-
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:508
+ // Only one of Callee or ProtoTypeLoc is set.
+ const FunctionDecl *Callee = nullptr;
+ FunctionProtoTy
nridge updated this revision to Diff 551390.
nridge added a comment.
Fix naming nit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158249/new/
https://reviews.llvm.org/D158249
Files:
clang-tools-extra/clangd/InlayHints.cpp
clang-tools-extra/cla
nridge added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:466
+// so that we can recover argument names from it.
+// FIXME: This function is mostly duplicated in SemaCodeComplete.cpp; unify.
+static FunctionProtoTypeLoc getPrototypeLoc(Expr *Callee) {
nridge added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:466
+// so that we can recover argument names from it.
+// FIXME: This function is mostly duplicated in SemaCodeComplete.cpp; unify.
+static FunctionProtoTypeLoc getPrototypeLoc(Expr *Callee) {
nridge created this revision.
nridge added reviewers: sammccall, hokein.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Re
