nridge added inline comments.
================
Comment at: clang-tools-extra/clangd/InlayHints.cpp:466
+// so that we can recover argument names from it.
+// FIXME: This function is mostly duplicated in SemaCodeComplete.cpp; unify.
+static FunctionProtoTypeLoc getPrototypeLoc(Expr *Callee) {
----------------
nridge wrote:
> The reason I didn't unify them in this patch is less that I'm lazy, and more
> that I'm not sure where to put code that will be shared by
> SemaCodeComplete.cpp and clangd.
>
> Do we have some sort of dumping ground for miscellaneous AST utilities, like
> `clang-tools-extra/clangd/AST.h` but also usable in libSema?
I guess the function is performing a heuristic / best-effort operation, so
HeuristicResolver could be the place for it once that is upstreamed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158249/new/
https://reviews.llvm.org/D158249
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
