nridge added a comment.
Committed, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157990/new/
https://reviews.llvm.org/D157990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
This revision was automatically updated to reflect the committed changes.
Closed by commit rG109bc024c8d7: [clangd] Add --query-driver flag to
clangd-indexer (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157990/new/
https://rev
tetsuo-cpp added a comment.
Thanks for the review @nridge! I'd really appreciate if you could help me with
the commit (I don't have commit access).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157990/new/
https://reviews.llvm.org/D157990
___
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thanks for the patch!
My thoughts are:
- As mentioned in the issue, I think this fills a logical gap: clangd-indexer
is an alternative way of generating a project index to clangd's background
tetsuo-cpp created this revision.
tetsuo-cpp added reviewers: sammccall, nridge.
tetsuo-cpp added projects: clang-tools-extra, All.
Herald added subscribers: kadircet, arphaman.
tetsuo-cpp requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
When using `clangd` for