nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land.
Thanks for the patch! My thoughts are: - As mentioned in the issue, I think this fills a logical gap: clangd-indexer is an alternative way of generating a project index to clangd's background indexer, so if clangd has a configuration feature needed for some projects (such as `--query-driver`), clangd-indexer should have an equivalent ability. (Processing `.clangd` config files is another such gap that I think would make sense to fill in the future.) - The implementation is straightforward. I don't think it's interesting enough to warrant spending time writing an automated test for this (especially given that our existing `system-include-extractor.test` is not particularly easy / pleasant to work with.) I would suggest waiting a few days to see if Sam has any input, otherwise I think this should be good to merge. Let me know if you need me to commit it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157990/new/ https://reviews.llvm.org/D157990 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
