[PATCH] D156234: [clang][deps] provide support for cc1 command line scanning

2023-07-25 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. This looks pretty good! I'm not sure unit testing is the best choice here, since we're not checking for low-level properties or hard-to-observe behavior. In general LIT tests are easier to write/maintain/understand and don't require recompiling, so I'd suggest to

[PATCH] D156234: [clang][deps] provide support for cc1 command line scanning

2023-07-25 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue updated this revision to Diff 544127. cpsughrue edited the summary of this revision. cpsughrue added a comment. Fixed formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156234/new/ https://reviews.llvm.org/D156234 Files: clang/lib/Tooling/DependencyScanning/Dep

[PATCH] D156234: [clang][deps] provide support for cc1 command line scanning

2023-07-25 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue created this revision. cpsughrue added reviewers: Bigcheese, jansvoboda11. Herald added a project: All. cpsughrue requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow users to run a dependency scan with a cc1 command line in addi