jansvoboda11 added a comment.
This looks pretty good!
I'm not sure unit testing is the best choice here, since we're not checking for
low-level properties or hard-to-observe behavior. In general LIT tests are
easier to write/maintain/understand and don't require recompiling, so I'd
suggest to transform the existing unit test into something similar to tests in
`clang/test/ClangScanDeps/`.
================
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:414
+ std::vector<std::string> Args = Action.takeLastCC1Arguments();
+ Consumer.handleBuildCommand({Executable, std::move(Args)});
+ return true;
----------------
================
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:507
+ // dependency scanning filesystem.
+ return createAndRunToolInvocation(Argv, Action, *FileMgr,
+ PCHContainerOps, *Diags, Consumer);
----------------
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156234/new/
https://reviews.llvm.org/D156234
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
